Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom manifest name #3000

Merged

Conversation

IanButterworth
Copy link
Member

Paired with JuliaLang/julia#44286

src/Types.jl Outdated Show resolved Hide resolved
src/Types.jl Outdated Show resolved Hide resolved
@IanButterworth

This comment was marked as resolved.

@DilumAluthge

This comment was marked as resolved.

@DilumAluthge

This comment was marked as resolved.

@DilumAluthge

This comment was marked as resolved.

@DilumAluthge

This comment was marked as resolved.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like that @static to be added, but other than that, this looks good to me.

src/Types.jl Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member

Once this PR is merged, we can bump the Pkg version on Julia master, and after that bump PR is merged, we can rebase JuliaLang/julia#44286.

src/Types.jl Outdated Show resolved Hide resolved
src/Types.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth merged commit 3aa1505 into JuliaLang:master Feb 22, 2022
@IanButterworth IanButterworth deleted the ib/handle_custom_maniffest_name branch February 22, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants