-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Manifest.toml format: Pt 2. Default to new format, warn if old format is being maintained #2580
New Manifest.toml format: Pt 2. Default to new format, warn if old format is being maintained #2580
Conversation
8389eab
to
4090996
Compare
One problem with deleting and running |
Nice. Done! |
0b184e8
to
cba6b0d
Compare
cba6b0d
to
3a36474
Compare
@StefanKarpinski @KristofferC Is this PR good to merge once CI turns green? |
I made it so that the upgrade manifest function also set the version field (I think that was omitted by accident). LGTM now. We will see if the warning gets too annoying but let's just focus on getting this in right now. |
@KristofferC it was intentional. I should've added a comment. I think the version needs to represent which julia version the resolve happened in, and given the tool just updates the format I don't think it's accurate to set the version field. |
That is true, let's take that back then :) |
New Manifest.toml format: Pt 2. (For 1.7 only, not to be backported to 1.6.2)
Continuation after part 1 (#2561)
Fixes #1458
Fixes #2508
Closes #2557