Improve inference of call chains to TOML.print #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a better fix for #1806, one that resolves the inference problems. A big part of the problem is the dreaded 15276.
StefanKarpinski
approved these changes
May 13, 2020
KristofferC
reviewed
May 14, 2020
| @@ -673,8 +673,10 @@ function bind_artifact!(artifacts_toml::String, name::String, hash::SHA1; | |||
| end | |||
|
|
|||
| # Spit it out onto disk | |||
| open(artifacts_toml, "w") do io | |||
| TOML.print(io, artifact_dict, sorted=true) | |||
| let artifact_dict = artifact_dict | |||
There was a problem hiding this comment.
I'm surprised this is needed, there is no assignment to artifact_dict so shouldn't the frontend be able to figure this out?
There was a problem hiding this comment.
I'm not a hundred percent certain but the codegen shows some try/catch stuff that appears to complicate the analysis. In practice, adding this suddenly gave much nicer codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better fix for #1806, one that resolves the inference problems. A big part of the problem is the dreaded 15276.
Addresses concerns in JuliaLang/www.julialang.org#794 (comment).