Remove a case of type piracy #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
I was wrong, it was being used somehow, subtly. EDIT: But only on Julia 1.0! |
tryBuild failed |
ararslan
force-pushed
the
aa/pirate-patrol
branch
from
b3cb972 to
fdeeca9
Compare
|
bors try |
|
I would prefer patch #1036 |
tryBuild succeeded |
|
Okay, up to you. I have a fix for another case of type piracy for which I can repurpose this PR. |
|
Cool, I'll merge the other one |
`in(::VersionNumber, ::VersionNumber)` was only used once and isn't necessary.
ararslan
force-pushed
the
aa/pirate-patrol
branch
from
356e250 to
415d621
Compare
|
bors try |
27 tasks
|
If you wanna fix #282 you can remove the |
|
I can wrap that definition in a version check once JuliaLang/julia#30947 is merged. |
tryBuild succeeded |
It is now defined in Base.
|
Version check added. bors try |
tryBuild succeeded |
|
Good to merge? |
00vareladavid
approved these changes
Feb 4, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 4, 2019
1035: Remove a case of type piracy r=ararslan a=ararslan Repurposed to fix #282. Co-authored-by: Alex Arslan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurposed to fix #282.