Test TOML #1012
Merged
Test TOML #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
StefanKarpinski
approved these changes
Jan 24, 2019
5 tasks
tryBuild failed |
seems unrelated |
|
Sometimes the network connection is faulty bors try |
tryBuild succeeded |
fredrikekre
reviewed
Jan 24, 2019
fredrikekre
reviewed
Jan 24, 2019
|
bors try |
tryBuild succeeded |
|
please squash to one commit and then we can merge. |
|
We can also just use the GitHub squash and merge button... |
|
Yea. Btw, my suggested way to test on multiple julia versions seems to not work... |
|
Squashed and (I believe) fixed the multiple Julia version testing |
|
It's a bit awkward that one must repeat the script part etc for each stage, but seems to be no other way... bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 24, 2019
1012: Test TOML r=fredrikekre a=iamed2 Co-authored-by: Eric Davies <[email protected]>
Build failed |
fredrikekre
reviewed
Jan 24, 2019
|
bors try |
|
Nice, seems to work. bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 24, 2019
1012: Test TOML r=fredrikekre a=iamed2 Co-authored-by: Eric Davies <[email protected]>
tryBuild succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a fake uuid for the TOML package, do you think something specific should go there?
Includes #1010
I modified number printing to fix the printing test. @StefanKarpinski does this impact you? I noticed you made the change that printed quoted values as a fallback.