Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sources section of Project.toml does not support subdir #4026

Open
piever opened this issue Sep 24, 2024 · 1 comment · May be fixed by #4039
Open

sources section of Project.toml does not support subdir #4026

piever opened this issue Sep 24, 2024 · 1 comment · May be fixed by #4039
Assignees
@KristofferC

Comments

@piever
Copy link

piever commented Sep 24, 2024

As discussed in Slack, attempting to specify a non-top-level package in a GitHub repo in the sources section of Project.toml errors.

MWE:

[deps]
DuckDB = "d2f5444f-75bc-4fdf-ac35-56f514c445e1"

[sources]
DuckDB = {url = "https://github.com/duckdb/duckdb", subdir = "tools/juliapkg", rev = "main"}

Calling Pkg.resolve() on the above project fails with

ERROR: Invalid key `subdir` in `source` section

For reference, DuckDB is a monorepo where the julia package is in the tools/juliapkg folder.

Version information (release candidate installed via juliaup):

julia> versioninfo()
Julia Version 1.11.0-rc3
Commit 616e45539db (2024-08-26 15:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
@KristofferC KristofferC self-assigned this Sep 24, 2024
@tecosaur tecosaur mentioned this issue Sep 25, 2024
Open
@tecosaur tecosaur linked a pull request Oct 7, 2024 that will close this issue
Open
@SamuelBrand1 SamuelBrand1 mentioned this issue Oct 9, 2024
Open
@oscardssmith
Copy link
Member

bump. I just ran into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristofferC KristofferC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow use of a url and subdir in [sources] tecosaur/Pkg.jl
3 participants
@KristofferC @piever @oscardssmith