-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL not identifying custom transformers #43
Comments
Currently the transformer list command only knows about transformers it's been explicitly told about, see what's currently done in DataToolkit.jl/Common/src/DataToolkitCommon.jl Lines 101 to 113 in dc8280f
(NB: I don't currently see a nicer way of fetching the documentation, but I think I could probably check for undocumented transformers and mention them at the end of |
I'm also planning on improving the docs a bit to make this a bit easier/soften the learning curve 🙂 |
Hi Completely understand regarding the documentation for the repl. No worries, I've realized I've mis-explained the real issue. Out of interest, have there been any major changes between v0.9.x to v0.10? I ask because my initial thought in trying to get a handle of how everything works was just to try and get dummy transformers working and see if the toolkit could recognize them. However I've since realized at least for the system to pick up the driver name's in
I am trying to implement a Parquet driver, however I get issues as above. My basic approach thus far been to create a Julia package and then inside there define all the loader logic (which is the only transformer I've actually needed to use since I can get the parquet files through https). I've tried following the approach of the example on this page My package file
Then I open julia session in the root directory of this package and run the following code
And my
Then I get the following error
Any help would be appreciated. Would love to be able get a parquet driver working so I can hopefully contribute if you'd like. |
Yup! I'm making a few major changes (a changelog probably wouldn't hurt 😅), such as:
Regarding the problem you've run into, it looks like you've given enough info for it to be a MWE. I'll see if I can give it a look in the next day or two, otherwise I'll probably get to it on the weekend 🙂. |
Good news, this error message is improved in 0.10-dev 🙂
More good news, I think you'll find this works if you actually import the functions you want to overload - export load, supportedtypes, create
+ import DataToolkitBase: load, supportedtypes, create It would be great to see a Paraquet driver, I should have some docs on adding a loader to |
Awesome thank you so much for update. Out of interest how would one add the v0.10-dev of the packages using the monorepo link to my Julia environment ? |
I'll warn that development is slightly volatile at the moment, but if you want to play around with v0.10-dev then once JuliaLang/Pkg.jl#4026 is fixed you can add this to your [deps]
DataToolkit = "dc83c90b-d41d-4e55-bdb7-0fc919659999"
DataToolkitBase = "e209d0c3-e863-446f-9b45-de6ca9730756"
DataToolkitCommon = "9e6fccbf-6142-406a-aa4c-75c1ae647f53"
DataToolkitCore = "caac3e55-418c-402e-a061-64d454aa8f4f"
DataToolkitREPL = "c58528a0-97a2-40a0-9a44-056fe1196995"
DataToolkitStore = "082ec3c2-3fb3-458f-ad22-5e5e31d4377a"
[sources]
DataToolkit = {rev = "main", subdir = "Main", url = "https://github.com/tecosaur/DataToolkit.jl.git"}
DataToolkitBase = {rev = "main", subdir = "Base", url = "https://github.com/tecosaur/DataToolkit.jl.git"}
DataToolkitCommon = {rev = "main", subdir = "Common", url = "https://github.com/tecosaur/DataToolkit.jl.git"}
DataToolkitCore = {rev = "main", subdir = "Core", url = "https://github.com/tecosaur/DataToolkit.jl.git"}
DataToolkitREPL = {rev = "main", subdir = "REPL", url = "https://github.com/tecosaur/DataToolkit.jl.git"}
DataToolkitStore = {rev = "main", subdir = "Store", url = "https://github.com/tecosaur/DataToolkit.jl.git"} |
Hi there,
I am trying to implement my own custom transformer named
customtransformer
. However when I try to run the?:
command in the REPL it doesn't pick these transformers up.I have a file called
custom_transformers.jl
which has the following contentI execute this file in the current Julia session and then run
Then when trying to list the transformers (using the
?:
command in the DataRepl) my custom transformer never shows up.What is the process to let
DataToolkit.jl
know about these custom transformers.The text was updated successfully, but these errors were encountered: