Do not put project stdlibs into the base (non-incremental) sysimage #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to do this, the stdlibs used by the project will be included when the final sysimage is built
|
Just FYI, a lot of the tests for non-incremental sysimages are failing on CI (due to #976), so I've disabled them and marked them as broken. So, if you want to see the impact of this PR, you'll likely need to re-enable those tests in your PR branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 3 3
Lines 823 823
=======================================
Hits 696 696
Misses 127 127 ☔ View full report in Codecov by Sentry. |
|
Removed all the test filtering for 1.11 and 1.12. |
27 tasks
|
CI is failing on Julia nightly, but is passing on all other Julia versions, including Julia 1.11. I think we can merge this PR, and then we can fix Julia nightly in a subsequent PR. |
|
Agree |
DilumAluthge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #976
There is no need to do this, the stdlibs used by the project will be included when the final sysimage is built