Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_known_hosts_file: fix bug with empty list (fix #11) #13

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

StefanKarpinski
Copy link
Member

No description provided.

We should return an empty file if there are no known hosts files
as this will cause no hosts to be considered known, which means
we're defaulting secure here.
@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #13 (a6abc4c) into master (af6efad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          108       108           
=========================================
  Hits           108       108           
Impacted Files Coverage Δ
src/ssh_options.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6efad...a6abc4c. Read the comment docs.

@StefanKarpinski StefanKarpinski merged commit a251de1 into master Dec 9, 2020
@StefanKarpinski StefanKarpinski deleted the sk/fix-empty-ssh-known-hosts-files branch December 9, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants