Add union(::OneTo, ::OneTo)
#704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
requested changes
Jun 3, 2020
Co-authored-by: Martin Holters <[email protected]>
Co-authored-by: Martin Holters <[email protected]>
|
I think this is good to go now! Thanks for the careful review, @martinholters |
martinholters
approved these changes
Jun 4, 2020
|
Hm, I'm having second thoughts as this changes the return type of In this case, I guess it's unlikely to cause any trouble (and JuliaLang/julia#35577 doesn't seem to have) so I'm in favor of merging as is, just wanted to point out this potential for problems and give others a bit more time to chime in. |
|
Well, no objections voiced, so here we go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't bump the version number because I see there's another recent merge request.