Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for JuliaLang/julia/pull/26436. #517

Merged
merged 1 commit into from
Mar 17, 2018
Merged

Fixes for JuliaLang/julia/pull/26436. #517

merged 1 commit into from
Mar 17, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Mar 16, 2018 •
edited
Loading

  • Add one argument "curried" forms of isequal, == and in.

  • Keep the following definitions to not break Compat on julia v0.6:

    • const EqualTo{T} = Fix2{typeof(isequal),T}
    • equalto(x) = isequal(x)
    • const OccursIn{T} = Fix2{typeof(in),T}
    • occursin(x) = in(x)

@nalimilan
Copy link
Member

Forget my previous comments, I had completely misread the VERSION checks. Looks fine to me (though I haven't followed JuliaLang/julia#26436 very closely). However, the OS X failure seems to be real, and might indicate that the code doesn't work with 0.7 versions before JuliaLang/julia#26436 was merged.

@fredrikekre
Copy link
Member Author

Passes locally now for v0.6, master and master just before JuliaLang/julia/pull/26436

nalimilan
nalimilan approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if you also confirm equalto and occursin continue to work on 0.6 for packages which had already been ported to them.

@fredrikekre
Fixes for JuliaLang/julia/pull/26436.
004d8f9 
- Add one argument ``curried'' forms of `isequal`, `==` and `in`.

- Keep the following definitions to not break Compat on julia v0.6:
   - const EqualTo{T} = Fix2{typeof(isequal),T}
   - equalto(x) = isequal(x)
   - const OccursIn{T} = Fix2{typeof(in),T}
   - occursin(x) = in(x)
@fredrikekre
Copy link
Member Author

Looks good if you also confirm equalto and occursin continue to work on 0.6 for packages which had already been ported to them.

Added tests for this.

@fredrikekre fredrikekre merged commit 0c7525e into master Mar 17, 2018
@fredrikekre fredrikekre deleted the fe/isequal branch March 17, 2018 14:55
@garrison
Copy link
Member

garrison commented Mar 20, 2018 •
edited
Loading

It would be nice if Compat.Fix2 existed regardless of julia version. Right now I have to do Fix2 = isdefined(Compat, :Fix2) ? Compat.Fix2 : Base.Fix2 in my user code.

garrison added a commit to garrison/UniqueVectors.jl that referenced this pull request Mar 20, 2018
@garrison
Work on julia 0.6 via Compat.Fix2
65bf9d5 
JuliaLang/Compat.jl#517
garrison added a commit that referenced this pull request Mar 21, 2018
@garrison
Make Compat.Fix2 always exist
68c2e7c 
Following #517 (comment)
@garrison garrison mentioned this pull request Mar 21, 2018
Merged
fredrikekre pushed a commit that referenced this pull request Mar 21, 2018
@garrison @fredrikekre
Make Compat.Fix2 always exist (#521)
294f171 
Following #517 (comment)
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for curried isequal, ==, and in from #517
2619e71 
And mark `Fix2` for deprecation.
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for curried isequal, ==, and in from #517
fb3f813 
And mark `Fix2` for deprecation.
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

@nalimilan nalimilan nalimilan approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

@ararslan ararslan Awaiting requested review from ararslan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredrikekre @nalimilan @garrison @stevengj