Cleanup Julia 0.7 deprecations #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure how to take care of these last two warnings on Julia 0.7: WARNING: the behavior of `A[I...] .= X` with scalar indices will change in the future. Use `A[I...] = X` instead.
Stacktrace:
[1] depwarn at ./deprecated.jl:68 [inlined]
[2] dotview(::Array{Int64,1}, ::Int64, ::Vararg{Int64,N} where N) at ./deprecated.jl:1792
[3] top-level scope at /Users/omus/.julia/v0.7/Compat/test/runtests.jl:434
[4] include_relative(::Module, ::String) at ./loading.jl:509
[5] include(::Module, ::String) at ./sysimg.jl:15
[6] process_options(::Base.JLOptions) at ./client.jl:334
[7] _start() at ./client.jl:400
in expression starting at /Users/omus/.julia/v0.7/Compat/test/runtests.jl:434
WARNING: the behavior of `A[I...] .= X` with scalar indices will change in the future. Use `A[I...] = X` instead.
Stacktrace:
[1] depwarn at ./deprecated.jl:68 [inlined]
[2] dotview(::Array{Int64,1}, ::Int64, ::Vararg{Int64,N} where N) at ./deprecated.jl:1792
[3] top-level scope at /Users/omus/.julia/v0.7/Compat/test/runtests.jl:461
[4] include_relative(::Module, ::String) at ./loading.jl:509
[5] include(::Module, ::String) at ./sysimg.jl:15
[6] process_options(::Base.JLOptions) at ./client.jl:334
[7] _start() at ./client.jl:400
in expression starting at /Users/omus/.julia/v0.7/Compat/test/runtests.jl:46 |
|
The CI logs look nice and clean. Just the two warnings I mentioned above remain. |
fredrikekre
added a commit
that referenced
this pull request
Nov 30, 2017
fredrikekre
added a commit
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates almost all the deprecations within Compat on Julia 0.7. Changes should be compatible with Julia 0.5 and 0.6 as well.