Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slope interval newton method #73

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eeshan9815
Copy link
Contributor

@dpsanders
Rebased "slope" and "debug-newton1d" branches onto this branch before adding more commits.

@eeshan9815
Copy link
Contributor Author

AppVeyor build is failing on Windows 32-bit, one of the 3D roots tests is failing.

@dpsanders
Copy link
Member

Could you rebase please?

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #73 into master will increase coverage by 0.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   64.97%   65.76%   +0.78%     
==========================================
  Files          11       11              
  Lines         551      552       +1     
==========================================
+ Hits          358      363       +5     
+ Misses        193      189       -4
Impacted Files Coverage Δ
src/slopes.jl 83.33% <ø> (+4.76%) ⬆️
src/IntervalRootFinding.jl 4.65% <ø> (ø) ⬆️
src/newton1d.jl 87.38% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0027a...8c45266. Read the comment docs.

@dpsanders
Copy link
Member

Another rebase required here...

@eeshan9815
Copy link
Contributor Author

Done!

@dpsanders
Copy link
Member

There's a real test error.

@eeshan9815
Copy link
Contributor Author

Sorry that happened due to an error while resolving the merge conflicts. It should work fine now.

@dpsanders
Copy link
Member

The function slope_newton1d should be refactored into the newton1d function, e.g. with a keyword arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants