Revert throwing an error for non-thin intervals #625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert PR #613 which broke code compatibility with 0.22.
At the time the PR #613 was made, it was wrongly assumed that no-one was relying on
==(::Interval, ::Number)
to work, since it has been in the past. This may not be the case, e.g. see lairez/ExactPredicates.jl#25.So the behaviour is as follows:
iszero
,isone
andisinteger
are semantically equivalent toisthinzero
,isthinone
andisthininteger
respectively. Their behaviour is in agreement to Base docstringsx == y
between an intervalx
and a numbery
is permitted and is semantically equivalent toisthin(x, y)
.