Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert throwing an error for non-thin intervals #625

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

OlivierHnt
Copy link
Member

@OlivierHnt OlivierHnt commented Feb 5, 2024

Revert PR #613 which broke code compatibility with 0.22.

At the time the PR #613 was made, it was wrongly assumed that no-one was relying on ==(::Interval, ::Number) to work, since it has been in the past. This may not be the case, e.g. see lairez/ExactPredicates.jl#25.

So the behaviour is as follows:

  • iszero, isone and isinteger are semantically equivalent to isthinzero, isthinone and isthininteger respectively. Their behaviour is in agreement to Base docstrings
  • x == y between an interval x and a number y is permitted and is semantically equivalent to isthin(x, y).

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ba420dc) 82.74% compared to head (5c8b757) 82.60%.

Files Patch % Lines
src/intervals/interval_operations/boolean.jl 0.00% 1 Missing ⚠️
src/intervals/real_interface.jl 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   82.74%   82.60%   -0.14%     
==========================================
  Files          25       25              
  Lines        2167     2144      -23     
==========================================
- Hits         1793     1771      -22     
+ Misses        374      373       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHnt OlivierHnt merged commit 1754eec into JuliaIntervals:master Feb 5, 2024
16 checks passed
@OlivierHnt OlivierHnt deleted the bool-error branch February 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants