Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RecipesBase as an extension #608

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

OlivierHnt
Copy link
Member

@OlivierHnt OlivierHnt commented Jan 4, 2024

Closes #605.

In the future we should add recipes like this for Makie.jl.

@OlivierHnt OlivierHnt merged commit c5994b4 into JuliaIntervals:master Jan 4, 2024
16 checks passed
@lorenzgillner
Copy link
Contributor

Please note that there is a typo in ext/IntervalArithmeticRecipesBaseExt.jl: in lines 5 and 19 AbstractVector is spelled incorrectly, resulting in an error when plotting boxes.

@OlivierHnt
Copy link
Member Author

🤦‍♂️ my bad

@Joel-Dahne
Copy link
Contributor

Looks good! Only comment I have is that it would maybe make sense to also support BareInterval. But I haven't really understood the new role of BareInterval, so it might not make sense.

@OlivierHnt
Copy link
Member Author

Indeed, that crossed my mind. But I figured, it is better to be a bit conservative, at least for the time being.

An important aspect of the 0.22 versions is that one should always use Interval and never BareInterval; except perhaps in performance critical code, where the user has also a clear understanding of the operations taking place to make sense of the output.
E.g.

julia> sqrt(bareinterval(-1, 1))
[0.0, 1.0]

julia> sqrt(interval(-1, 1))
[0.0, 1.0]_trv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting intervals after removal of IntervalBox
3 participants