Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for C stack checking issues on 1.1 #293

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Fix for C stack checking issues on 1.1 #293

merged 2 commits into from
Feb 1, 2019

Conversation

simonbyrne
Copy link
Member

Fixes #289.

@simonbyrne
Copy link
Member Author

This seems to work interactively on Mac.

@randy3k
Copy link
Member

randy3k commented Jan 18, 2019

@Non-Contradiction , I believe this doesn’t fix the issue of JuliaCall since JuliaCall does not initialize R. We might need to put the same fix at a different location for JuliaCall.

@randy3k
Copy link
Member

randy3k commented Jan 18, 2019 •
edited
Loading

One more thing, on Windows, instead of Rf_initialize_R we should call R_set_command_line_arguments. Otherwise, the Rstart configuration will be replaced.

Edit: It is not relevant because the patch is only applied on unix platform.

@Non-Contradiction
Copy link
Contributor

Yes, adding unsafe_store!(cglobal((:R_CStackLimit,RCall.libR),Csize_t), typemax(Csize_t)) in the julia_setup() fix the problem in julia REPL in JuliaCall.

@randy3k
Copy link
Member

randy3k commented Jan 26, 2019

It seems that we also need a fix for Windows. See #289 (comment)

@randy3k randy3k force-pushed the sb/stack branch 4 times, most recently from 853860d to 0794f9e Compare January 31, 2019 12:37
@randy3k randy3k mentioned this pull request Jan 31, 2019
Closed
@randy3k
Copy link
Member

randy3k commented Feb 1, 2019

Let's merge it to master and make a release.

@randy3k randy3k merged commit 2d9bb75 into master Feb 1, 2019
@randy3k randy3k deleted the sb/stack branch February 1, 2019 16:14
@bicycle1885
Copy link

When can I see the next release including this patch? I want to use an official version of RCall.jl on Julia 1.1.

@randy3k
Copy link
Member

randy3k commented Feb 5, 2019 •
edited
Loading

It's pending to be released JuliaLang/METADATA.jl#21150

@bicycle1885
Copy link

Great! Thank you very much!

@aviks aviks mentioned this pull request Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonbyrne @randy3k @Non-Contradiction @bicycle1885