Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up temporary files in tests. Fixes #8. #23

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 11, 2017

CC @tkelman (sorry this got forgotten).

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Sigh. Now that we fixed one 0.6 problem (ColorTypes), we get to discover others. JuliaMath/FixedPointNumbers.jl#74.

Someday, the whole Colors/Images suite will pass on 0.6.

@timholy timholy merged commit 06624f0 into master Feb 11, 2017
@timholy timholy deleted the teh/tempfiles branch February 11, 2017 12:22
@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2017

did you formerly have appveyor running here?

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

JuliaImages doesn't show up among the list of projects that I can add to AppVeyor. Almost everything else does. Any ideas?

@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2017

Very odd. You might need to log out then log back in, but select a different account in the dropdown you get

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

I've tried all the ones I have.

@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2017

May need to grant it org privileges in the github settings?

@Evizero
Copy link
Member

Evizero commented Feb 11, 2017

You may need to click some "sync" button somewhere. I have had such issues before on CI related sites where packages or an org didn't show up.

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Can't find a sync button to push on AppVeyor. Checking against JuliaGraphics (which does show up), there don't seem to be any org settings for AppVeyor. However, there is one big difference: in JuliaImages, under "Third-party access" it seems we have access restrictions in place. AppVeyor is one of the approved applications, however. I just tried "denying" it and then re-approving it. That didn't seem to change anything on the AppVeyor side.

Crazy to turn off access restrictions?

Because it took me surprisingly long to find these, I'm leaving some breadcrumbs:
https://help.github.com/articles/requesting-organization-approval-for-your-authorized-applications/
https://help.github.com/articles/approving-third-party-applications-for-your-organization/

@SimonDanisch
Copy link
Member

I can confirm that all the usual tricks didn't help :(

@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2017

Could also email [email protected] (or maybe now it's [email protected]?), it's the weekend but worth a shot anyway

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Email sent.

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Fixed thanks to @FeodorFitsner. It was enabled for AppVeyor but it had never been requested for AppVeyorCI. I've turned it on for most of the repos, but let me know if there are any missing.

@tkelman
Copy link
Contributor

tkelman commented Feb 12, 2017

Lovely. Could we fire off a build on master here?

@SimonDanisch
Copy link
Member

did just that (I think) ;)

@timholy
Copy link
Member Author

timholy commented Feb 12, 2017

With brand-new segfaulting on 0.5 and brand-new ambiguities in FixedPointNumbers on the latest nightly (JuliaMath/FixedPointNumbers.jl#74), this is unlikely to be informative. Unless magically JuliaLang/METADATA.jl#7926 gets merged before the 0.6 tests fire.

@timholy
Copy link
Member Author

timholy commented Feb 12, 2017

How does so much fall apart in 24 hours? 😦

@tkelman
Copy link
Contributor

tkelman commented Feb 12, 2017

I'm mostly wanting to see if windows is able to get through a run, given permission requirements there

@timholy
Copy link
Member Author

timholy commented Feb 12, 2017

Reasonable thing to want to know. I already tested that on a different repo (JuliaImages/ImageAxes.jl#14), which happened to be first alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants