Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we reexport Colors and FixedPointNumbers? #74

Closed
johnnychen94 opened this issue Apr 25, 2019 · 5 comments
Closed

can we reexport Colors and FixedPointNumbers? #74

johnnychen94 opened this issue Apr 25, 2019 · 5 comments

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Apr 25, 2019

Any nontrivial downstream packages need to use these two packages.

                         ImageCore           Colors              FixedPointNumbers   ColorTypes          ColorVectorSpace    
Images                   ✅                   ✅                   ✅                   ✅                   ✅                   
ImageMetadata            ✅                   ✅                   ✅                   ❌                   ✅                   
ImageFiltering           ✅                   ✅                   ✅                   ❌                   ✅                   
ImageAxes                ✅                   ✅                   ✅                   ❌                   ❌                   
ImageMorphology          ✅                   ❌                   ❌                   ❌                   ❌                   
ImageView                ❌                   ✅                   ✅                   ❌                   ✅                   
ImageSegmentation        ❌                   ❌                   ❌                   ❌                   ❌                   
ImageDistances           ❌                   ✅                   ❌                   ❌                   ❌                   
TestImages               ❌                   ❌                   ❌                   ❌                   ❌                   

Where ImageSegmentation and ImageView have Images dep, and ImageMorphology and ImageDistances are still under development.

Perhaps reexport ColorVectorSpace as well.

script
using ProgressMeter
using Suppressor
using Pkg.TOML: parsefile
using Formatting

bool2emoji(x) = if x "" else "" end
  
function filter_dep(pkg_names, toml_url)
  toml_filename = "Project.tmp.toml"
  @suppress run(`curl -q $toml_url -o $toml_filename`)
  deps = parsefile(toml_filename)["deps"] |> keys
  rm(toml_filename)
  
  map(pkg_names) do pkg
    result = (pkg in deps) .|> bool2emoji
  end
end

function format_print(head_column, columns)
  printfmt("{1:<25s}", head_column)
  foreach(columns) do c
    printfmt("{1:<20s}", c)
  end
  println()
end

package_list = ["Images", "ImageMetadata", "ImageFiltering", "ImageAxes", "ImageMorphology", "ImageView", "ImageSegmentation", "ImageDistances", "TestImages"]
package_of_interest_list = ["ImageCore", "Colors", "FixedPointNumbers", "ColorTypes", "ColorVectorSpace"]

deps_list = @showprogress map(package_list) do pkg
  pkg_url = "https://raw.githubusercontent.com/JuliaImages/$pkg.jl/master/Project.toml"
  filter_dep(package_of_interest_list, pkg_url)
end
sleep(0.1)

format_print(" ", package_of_interest_list)
foreach(deps_list, package_list) do deps, pkg
  format_print(pkg, deps)
end

# using DataFrames
# DataFrame(Dict(zip(["Dep", package_list...], [package_of_interest_list, deps_list...])))

related issue: JuliaImages/Images.jl#792

@johnnychen94
Copy link
Member Author

johnnychen94 commented Apr 26, 2019

ping @timholy (Should I ping you here and there every few days to get updates?)

Sent from mini-github

@timholy
Copy link
Member

timholy commented Apr 27, 2019

Pinging me is good. Realistically these days I only have an hour or so per day for Julia (I end up spending more, sometimes too much) and every issue requires bandwidth, so I deliberately ignore a lot of stuff. Please don't take offense at this, it's purely a matter of survival for me. I don't take offense at pings, as long as it's understood that sometimes I'll have to ignore it. If you keep pinging me occasionally it will eventually get through as I cross other higher-priority items off my list; a good strategy is to reserve it for your highest priorities and then, as things get addressed, work your way downward.

WRT to this issue, it's fine to reexport those, I think that's a good idea. ColorVectorSpace doesn't export anything.

@juliohm
Copy link
Member

juliohm commented Apr 27, 2019 via email

@timholy
Copy link
Member

timholy commented Apr 27, 2019

Of course 😄

@juliohm
Copy link
Member

juliohm commented Apr 27, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants