Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize zip_findlast_entry and add benchmarks #81

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Optimize zip_findlast_entry and add benchmarks #81

merged 1 commit into from
Oct 6, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 6, 2024

main dirty main/dirty
reading/ZipReader 0.0427 ± 0.0026 ms 0.0429 ± 0.0027 ms 0.995
reading/zip_findlast_entry first 7.02 ± 0.1 μs 7.45 ± 0.08 μs 0.942
reading/zip_findlast_entry last 0.08 ± 0.01 μs 0.07 ± 0.01 μs 1.14
reading/zip_findlast_entry nothing 5.47 ± 0.27 μs 1.15 ± 0.04 μs 4.75
reading/zip_readentry 5.62 ± 1.2 μs 5.59 ± 1.2 μs 1.01
time_to_load 0.0559 ± 0.00035 s 0.0574 ± 0.00036 s 0.974

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (237b528) to head (25e115e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           6        6           
  Lines         791      792    +1     
=======================================
+ Hits          789      790    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 merged commit 96de730 into main Oct 6, 2024
18 checks passed
@nhz2 nhz2 deleted the string-opt branch October 6, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant