Drop v0.6 support #124
Merged
Drop v0.6 support #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current failure is JuliaIO/ImageMagick.jl#130. |
kmsquire
force-pushed
the
feature/drop-v0.6
branch
4 times, most recently
from
f68e7bf to
9e38142
Compare
* This is an attempt to resolve the current zlib issues
* ImageMagick is imported on demand by FileIO * If VideoIO is imported first, it loads ffmpeg/libav libraries. These libraries may be linked against the system libz. If they are, and ImageMagick is loaded later, it attemtps to use the already loaded version of libz, and may fail to load because it requires a later version.
kmsquire
force-pushed
the
feature/drop-v0.6
branch
3 times, most recently
from
bc82c12 to
31d7d07
Compare
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=========================================
Coverage ? 89.22%
=========================================
Files ? 21
Lines ? 232
Branches ? 0
=========================================
Hits ? 207
Misses ? 25
Partials ? 0
Continue to review full report at Codecov.
|
* For some reason, the value scaling of the images used to compare the first (non-blank) video frame has changed
* The function is testing whether the last read video frame was blank, so it was misnamed!
* This is a separate commit which just contains formatting changes for files in the next commit, to make reviewing easier
* Previously, we were using findfirst to get the field position of a particular struct element. * Our use of findfirst was deprectated, so fix the deprecation * Additionally, reduce code duplication with a function, fieldposition, which returns the position of the field within a struct
* In build.jl, we were assigning variable names inside of an array initialization * This is no longer allowed in Julia v1.0
kmsquire
force-pushed
the
feature/drop-v0.6
branch
from
d222003 to
ff79e81
Compare
* Drop testing on v0.7 (tests pass on v1.0, and therefore should pass on v0.7) * Don't allow nightly to fail (yet)
kmsquire
force-pushed
the
feature/drop-v0.6
branch
from
941fac9 to
7f3586a
Compare
|
Tests pass! For anyone following at home, this is still somewhat limited:
Going to merge and tag, and start work on on other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.