Fix breakage after base unexported at-with #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to get this merged and released because it's leading to MixedModels.jl tests failing on 1.11 and nightly. |
joachimbrand
approved these changes
Mar 23, 2024
|
Thanks; this was breaking some CI. Also, why was that merged into JuliaLang? Doesn't seem to follow SemVer? |
|
@MilesCranmer 1.11 isn't yet released and this only became available on 1.11, so now is the time to make such changes. |
|
Ping, can this be merged? |
yuyichao
force-pushed
the
yyc/scopedvalues
branch
from
66f0e10
to
74c8068
Compare
|
Seems that #63 should fix the error for the latest version although as clarified in JuliaLang/julia#53628 the correct fix should be to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref JuliaLang/julia#53004