New feature: compressor can take streams larger than typemax(UInt32) bytes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really cool, if this could be merged. |
|
Yea, let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into problems with large streams, which is because the
ZStreamstructure only takesUInt32for e.g.avail_in; and so does the zlib backend.I made some small adjustments to work around that, tests are passed with this modification.
I haven't added a test for the compression of large streams, as it might cause an OOM.
The decompressor wasn't modified, but in all cases I tested no problem occurred, maybe someone with a better understanding of the matter can have a look?
Cheers, Felix.