-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors on 1.7 #102
Fix errors on 1.7 #102
Conversation
Okay all the errors should have been resolved @DhairyaLGandhi |
It seems we were only running into that issue for @vtjnash can you comment on what the |
It is unlikely that you should be trying to access internal functions via ccall. The allocator for |
168d069
to
bf7228b
Compare
@CarloLucibello I don't have commit rights here, can you review? The fixes here touch internals, but it is no more hacky than the rest of the package in that regard. A full overhaul to make the package more stable in the long term is needed (we already see failures on nightly), but not a task that I can complete in the near future. I would suggest this is merged so that BSON.jl is usable on 1.7. |
old tests are passing, new tests are added, good enough for me |
We should tag a patch release too |
done |
DataType
no longer has amutable
field. The new functionismutabletype
can be used instead. Similarly,abstract
is nowisabstracttype
.jl_new_datatype
now takes in afattrs
argument which I think should beT.atomicfields
(maybe @vtjnash can correct me). The change was added in JuliaLang/julia#37847Only remaining error is that accessing the fieldN
forVararg{T}
is now an undefined reference.Fixes #107