Fixes to make the code compile again #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function IntrinsicLowering::AddPrototypes was removed.
Change the signature to TargetSubtargetInfo::TargetSubtargetInfo in accordance with LLVM.
|
Which version of LLVM are you using? |
|
Ok, I thought I was on branch In any case, the code compiles and the tests run successfully. Maybe you can use this in the future, otherwise you can close the PR. |
|
Maybe make these changes with an |
|
LLVM 9 is released now, so the PR should be applicable. |
|
Can you update the README to say this now targets LLVM 9, and we can merge this. |
|
Please don't break prior LLVM versions in the process (talking about that second commit, perhaps using an #ifdef there?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the instructions in the readme there were two compilation errors. This PR contains the changes needed to make the C backend compile.