Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Documenter 1 and update CompatHelper #59

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

devmotion
Copy link

@devmotion devmotion commented Oct 5, 2023

The PR updates the makedocs call in docs/make.jl to Documenter 1 and removes the keyword arguments that were removed in Documenter 1. To avoid such issues with breaking changes in the future, I also added compat entries to docs/Project.toml, as suggested by the Documenter docs, and enabled CompatHelper for the docs environment. I used the opportunity to update the CompatHelper action with the template in the CompatHelper repo.

Should fix the docs build failure in #58.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #59 (c5fffa7) into master (f16fa63) will decrease coverage by 0.87%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   98.32%   97.45%   -0.87%     
==========================================
  Files           8        9       +1     
  Lines         538      551      +13     
==========================================
+ Hits          529      537       +8     
- Misses          9       14       +5     

see 3 files with indirect coverage changes

doc strings of internal functions
@hexaeder hexaeder merged commit 7014c46 into JuliaGraphs:master Oct 6, 2023
@hexaeder
Copy link
Collaborator

hexaeder commented Oct 6, 2023

Thanks again! I'll have a look at the new docs once they are built on master and tag the new version afterward.

@devmotion devmotion deleted the dw/docs branch October 6, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants