-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Base.eltype
works on graph types as well as instances
#144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes me wonder if it's okay to call this method eltype
since AbstractGraph
is not iterable. I don't think it is too bad, we should better not break anything.
I removed the implementations for |
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 97.23% 97.26% +0.02%
==========================================
Files 114 114
Lines 6583 6579 -4
==========================================
- Hits 6401 6399 -2
+ Misses 182 180 -2 |
According to the Julia documentation,
eltype
should be defined on the::Type{AbstractGraph}
instead of the instances themselves:Currently, however:
This PR fixes this to return