Avoid capturing external variables into closures #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around a notorious performance problem with closures in julia
JuliaLang/julia#15276
that recently triggered a bug in Zygote
FluxML/Zygote.jl#1290
that made NNConv gradient tests fail (#208)
We now avoid message function capturing external variables by adding additional
propagate
andapply_edges
method.These new methods take as input a GNNLayer as well and pass it to the message function.
We also make all internal types concrete for conv structs, which could improve performances on small graphs.
Fix #208