Split GraphIO into submodules #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 99.66% 99.67% +<.01%
==========================================
Files 9 10 +1
Lines 296 304 +8
==========================================
+ Hits 295 303 +8
Misses 1 1
Continue to review full report at Codecov.
|
|
FWIW, I am completely in favor of this PR. Please resolve the conflicts (introduced by my PR; sorry!) and I'll approve / merge ASAP. |
|
also cc @StefanKarpinski to see whether we can do something interesting with Pkg3 here. |
|
@simonschoelly thank you again for all your hard work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past,
GraphIO.jlhad problems with various dependencies that where not up to date. I order to fix this, the idea is, to split this package into multiple packages but keep them in the same repository. This way, if one dependency fails, the file-formats that do not depend on this dependency can still be used.Unfortunately, the Julia ecosystem does completely support this yet. Therefore this PR splits
GraphIO.jlinto different submodules that can later be made into packages.I use
Revise.jlto dynamically load the submodules that depend onEzXML.jlandParserCombinatoronly when these packages are imported. Originally I wanted to load them, when Julia detects that these packages are installed, but I can't find a clean way to do that, where there are no strange warnings and where I can be sure that there are no unwanted side effects.The interface changes insofar, as that a users has to access a file-format in its submodule. E.g. instead of calling
GraphIO.Graph6Format(), they now have to callGraphIO.Graph6.Graph6Format(). As this might break some code, I added some deprecations warnings.