Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pack(::Canvas) and support kwargs in grid(::Canvas, ...) #156

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix pack(::Canvas) and support kwargs in grid(::Canvas, ...) #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a51531
fix pack(::Canvas) and support kwargs in grid(::Canvas, ...)
LilithHafner Jul 19, 2024
c7b39e3
Merge branch 'master' into lh/fix-canvas-placement
LilithHafner Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tkwidget.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,12 +408,12 @@

initialized(c::Canvas) = c.initialized

function pack(c::Canvas, args...)
pack(c.c, args...)
function pack(c::Canvas; kwargs...)
pack(c.c; kwargs...)

Check warning on line 412 in src/tkwidget.jl

View check run for this annotation

Codecov / codecov/patch

src/tkwidget.jl#L411-L412 

Added lines #L411 - L412 were not covered by tests
end

function grid(c::Canvas, args...)
grid(c.c, args...)
function grid(c::Canvas, args...; kwargs...)
grid(c.c, args...; kwargs...)

Check warning on line 416 in src/tkwidget.jl

View check run for this annotation

Codecov / codecov/patch

src/tkwidget.jl#L415-L416 

Added lines #L415 - L416 were not covered by tests
end

function place(c::Canvas, x::Int, y::Int)
Expand Down
Loading