Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha settings in placeimage() #156

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Conversation

Sov-trotter
Copy link
Contributor

The placeimage function for image matrix can use some alpha settings similar to the ones for png/svg.

The placeimage function for image matrix can use some alpha settings similar to the ones for png/svg.
@Sov-trotter
Copy link
Contributor Author

@cormullion could you take a look at this? Thanks.

@cormullion
Copy link
Member

Looks cool! You'll probably need to update docstrings and docs, and perhaps add tests - since this stuff is (I think) used by the Javis folks. (@Wikunia will be unhappy if I muck this up again! JuliaAnimators/Javis.jl#149).

@Sov-trotter
Copy link
Contributor Author

Will do that. Thanks

@cormullion cormullion merged commit 5421b99 into JuliaGraphics:master Jun 11, 2021
@cormullion
Copy link
Member

cormullion commented Jun 11, 2021

Good stuff! Thanks!

@Wikunia
Copy link
Contributor

Wikunia commented Jun 11, 2021

Haha @cormullion I'm always happy with you!
Does this change some Javis stuff now? As @Sov-trotter is working on Javis I suppose he'll notice though 😄

@cormullion
Copy link
Member

:) I worry that I might change something small and ruin your day... 😃

@Sov-trotter
Copy link
Contributor Author

Thanks @cormullion .
Could you tag a minor release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants