Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Usage of Gtk on windows needs a warning #454

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Nov 26, 2019

After the second time wasting quite a bit of time to debug why everything is suddenly sluggish, until I noticed that some unexpected third party library was loading Gtk, I come to the conclusion that we really need this warning.

After the second time wasting quite a bit of time to debug why everything is suddenly sluggish, until I noticed that some unexpected third party library was loading in Gtk, I come to the conclusion that we really need this warning.
@giordano
Copy link
Contributor

I think this should be fixed in #447, if I remember correctly by https://github.com/JuliaGraphics/Gtk.jl/pull/447/files#diff-8c2b506e7179e52e816713686d731068 in particular

@SimonDanisch
Copy link
Member Author

That'd be awesome! Not really a reason against merging this, I guess ;)
Once #447 lands and removes the problem we can get rid of the warning!

@SimonDanisch
Copy link
Member Author

Oh, bad news Btw...From all I can see, I'm using #447, so doesn't seem fixed...

@davidanthoff
Copy link

Yes, very much in favor of merging this, I've been bitten too many times by this!

@jonathanBieler
Copy link
Collaborator

I'm fine with merging this.

@jonathanBieler jonathanBieler merged commit cfcfdf5 into master Nov 28, 2019
@SimonDanisch SimonDanisch deleted the sd/windows branch November 28, 2019 10:49
@tknopp
Copy link
Collaborator

tknopp commented Nov 28, 2019

I am not so happy with the warning, but its the peoples choice who use windows. @jonathanBieler are you using Windows? Did the fix of @vtjnash really did not fix the issue? On OSX it did.

The plan now is as follows:

  • Lets put upper bounds on all depending packages and make a release
  • Then merge the JLL branch
  • Wait for all depending JLL branches (Cairo!) to be released
  • Release a new release for Julia >= 1.3

@giordano
Copy link
Contributor

Maybe merge Cairo jll pull request before the one for gtk?

@tknopp
Copy link
Collaborator

tknopp commented Nov 28, 2019

Thats what I said with the third point, no?

@tknopp
Copy link
Collaborator

tknopp commented Nov 28, 2019

I mean for 2/3 it does not really matter to much, what the order is.

@jonathanBieler
Copy link
Collaborator

I haven't used Gtk on windows for a while (I could give it a try) but as I understand the underlying issue has never been tackled (or maybe I missed it). #325 #181

@tknopp
Copy link
Collaborator

tknopp commented Nov 28, 2019

The "fix" is in the JLL branch, see this:
https://github.com/JuliaGraphics/Gtk.jl/pull/447/files#diff-8c2b506e7179e52e816713686d731068L353

The communication is within the binarybuilder channel of slack. This was done by Jameson and Elliot.

@tknopp
Copy link
Collaborator

tknopp commented Nov 29, 2019

note that I needed dropping this as it conflicted badly with the JLL branch that has priority. The function where this was integrated was not present in the JLL branch :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants