Deprecate StatsBase #135
Merged
Deprecate StatsBase #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also PR #132 on CI. (It's optional, though.) |
|
I'd be fine to switch, I just wasn't sure whether that was ready yet. |
timholy
force-pushed
the
teh/deprecate_statsbase
branch
from
28924b1
to
aff2157
Compare
|
I'm probably going to need some help here...not very familiar with GitHubActions yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we've decided that depwarns aren't breaking, so before #131 lands let's deprecate StatsBase. Given that we now have strong [compat] bounds and we've been encouraging people to shift away from
imhistfor a long time, perhaps we don't need to leave that deprecation in place for very long.This also marks one test as broken, ref #134.