WIP: preparation for v0.7 #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Aug 6, 2017
test/runtests.jl
Outdated
| @@ -210,7 +211,7 @@ end | |||
|
|
|||
| if Cairo.libcairo_version >= v"1.12.0" | |||
|
|
|||
| if ~is_windows() | |||
| if ~Sys.iswindows() | |||
There was a problem hiding this comment.
will need to raise Compat min version, in either test/REQUIRE or REQUIRE
There was a problem hiding this comment.
It will also have to be invoked as Compat.Sys.iswindows()
There was a problem hiding this comment.
@ararslan But that might be a Compat documentation issue
is_apple, is_bsd, is_linux, is_unix, and is_windows are now Sys.isapple, Sys.isbsd, Sys.islinux, Sys.isunix, and Sys.iswindows, respectively. These are available in the Compat.Sys submodule.
reads for me like using Compat.Sys and apply Sys.
There was a problem hiding this comment.
Yeah, that's a failure of the documentation.
julia> using Compat.Sys
julia> Sys.iswindows()
WARNING: both Sys and Base export "Sys"; uses of it in module Main must be qualified
ERROR: UndefVarError: Sys not defined
Though actually it appears to work (at least on 0.6) with import Compat.Sys.
1 similar comment
1 similar comment
Merged
|
NOTE: this will be superceeded by #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.