Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %APPDATA% directory on Windows (for real this time). #286

Merged
merged 3 commits into from
May 25, 2019

Conversation

twavv
Copy link
Member

@twavv twavv commented May 18, 2019

Tested on Windows.

@twavv
Copy link
Member Author

twavv commented May 18, 2019

Fixes #279.

@twavv
Copy link
Member Author

twavv commented May 18, 2019

Ping @shashi as well. This removes the configuration in the JSON file (jupyter_notebook_config.json) -- the JSON file shouldn't(?) work anyway because it won't have the location of the jlstaticserve.py in sys.path.

Was there a reason for adding that in the first place or am I missing something?

@twavv
Copy link
Member Author

twavv commented May 18, 2019

Oh, I see: #160 is relevant here.

I think the fix is to add to sys.path in the .py file and add the nbserver_extensions bit only in the JSON. I will make that change.

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files          15       15           
  Lines         615      615           
=======================================
  Hits          350      350           
  Misses        265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119a22b...53a0f56. Read the comment docs.

@twavv
Copy link
Member Author

twavv commented May 20, 2019

@rdeits @SimonDanisch
You're recommended by GitHub so you're being dragged into this. Can I get a pair of eyes on this before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants