Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading / from AssetRegsitry key #282

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

shashi
Copy link
Member

@shashi shashi commented May 9, 2019

This fixes errors in some cases where // ends up in the URL.

@shashi shashi changed the title remove trailing / from AssetRegsitry key remove leading / from AssetRegsitry key May 9, 2019
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files          15       15           
  Lines         615      615           
=======================================
  Hits          350      350           
  Misses        265      265
Impacted Files Coverage Δ
src/imports.jl 59.18% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df601b...efce850. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files          15       15           
  Lines         615      615           
=======================================
  Hits          350      350           
  Misses        265      265
Impacted Files Coverage Δ
src/imports.jl 59.18% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df601b...efce850. Read the comment docs.

@shashi shashi merged commit 119a22b into master May 10, 2019
@twavv twavv deleted the s/fix-trailing-slash branch December 22, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants