Switch to .toml files for new Pkg3 Registry process #202
Conversation
- Add Project.toml, Manifest.toml - Remove REQUIRE Directly converted our version specifications from the REQUIRE file (ie kept them as their corresponding `>=` meaning.
|
Oh and also, @pfitzseb, I think I remember that you are in the anti-manifest file camp? I think I am in the opposed group as well, since it will hide breakages in upstream packages from our CI unless we keep it up-to-date. I think I vote for removing it, but i wanted to upload it here just for posterity. :) |
|
You'll need to change the TravisCI file. script:
- $TESTCMD -e 'using Pkg; Pkg.build(); Pkg.test("Blink"; coverage=true)'Manifest should be removed imo (it will just create git diff noise and serve no purpose). |
|
WebIO PR: JuliaRegistries/General#1473 |
Ah, thanks, good call! :) I've also changed the travis command for our docs build, which will hopefully work correctly as well.
👍 I removed the Manifest file as well. Thanks! |
|
@travigd actually, unfortunately it looks like the latest WebIO Can that version be fixed and maybe you can bump the breaking changes to be (Blink) pkg> test Blink
...
Testing Blink tests passed
(Blink) pkg> update
Updating registry at `~/.julia/registries/General`
Updating git-repo `https://github.com/JuliaRegistries/General.git`
Resolving package versions...
Installed WebIO ─ v0.8.6
Updating `~/.julia/dev/Blink/Project.toml`
[0f1e0344] ↑ WebIO v0.8.5 ⇒ v0.8.6
Updating `~/.julia/dev/Blink/Manifest.toml`
[cd3eb016] ↑ HTTP v0.8.2 ⇒ v0.8.3
[0f1e0344] ↑ WebIO v0.8.5 ⇒ v0.8.6
Building WebIO → `~/.julia/packages/WebIO/9qsL8/deps/build.log`
(Blink) pkg> build
Building MbedTLS → `~/.julia/packages/MbedTLS/X4xar/deps/build.log`
Building WebIO ──→ `~/.julia/packages/WebIO/9qsL8/deps/build.log`
Building Blink ──→ `~/.julia/dev/Blink/deps/build.log`
Resolving package versions...
(Blink) pkg> test Blink
Testing Blink
Resolving package versions...
ERROR: LoadError: Javascript error Error: Cannot find module 'debug' |
|
(and to clarify, i get the same issues even if I pin (Blink) pkg> test Blink
Testing Blink
Resolving package versions...
ERROR: LoadError: Javascript error Error: Cannot find module 'debug'
...
ERROR: Package Blink errored during testing
(Blink) pkg> status
Project Blink v0.11.0
Status `~/.julia/dev/Blink/Project.toml`
...
[cd3eb016] + HTTP v0.8.2 #6748814 (https://github.com/JuliaWeb/HTTP.jl.git) ⚲
...
[0f1e0344] + WebIO v0.8.6
... |
|
Cool! Sorry this got dropped for two weeks. I was hoping to finish it before I went on vacation all of last week, but didn't manage it. Blink is now broken on master from the latest WebIO change; I've opened an issue about it here: JuliaGizmos/WebIO.jl#317 In the meantime I guess we could also change our compatability to more specifically upper-bound against |
WebIO v0.8.6 broke Blink, so we're downgrading to 0.7 for now. More info on this issue, here: JuliaGizmos/WebIO.jl#317
|
Okay, I've just gone ahead and downgraded |
NHDaly
force-pushed
the
register-Pkg3-Registry
branch
from
31216ac to
e0ecc45
Compare
|
Alright, everything's green. Wanna merge + tag? :) |
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 41.09% 45.63% +4.53%
==========================================
Files 10 12 +2
Lines 292 309 +17
==========================================
+ Hits 120 141 +21
+ Misses 172 168 -4
Continue to review full report at Codecov.
|
I directly converted our version specifications from the REQUIRE file (ie kept them as their corresponding
>=meaning), giving us:https://github.com/NHDaly/Blink.jl/blob/2c6e94d392b13cf20c6a0f025d31e57b187c9776/Project.toml#L22-L26
But I think more likely than not, we probably want to switch these to be semver versions. But I guess we should reflect first on whether those versions are even up to date anymore? I vaguely recall wanting to set some upper bound version requirements in the past and not being able to, but I don't think we have any such problems right now.
Any thoughts on what's best for this?
Thanks!