Lazy2d

[jw3126]

fix #14.
I noticed one gotcha (that is also present in AngleAxis).

julia> using Rotations

julia> r = Angle2d(1); @show eltype(r); @show typeof(r[1])
eltype(r) = Int64
typeof(r[1]) = Float64

[codecov-io]

Codecov Report

Merging #89 into master will decrease coverage by 0.13%.
The diff coverage is 82.6%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   87.11%   86.97%   -0.14%     
==========================================
  Files           9        9              
  Lines         722      745      +23     
==========================================
+ Hits          629      648      +19     
- Misses         93       97       +4

Impacted Files	Coverage Δ
src/Rotations.jl	100% <ø> (ø)	⬆️
src/core_types.jl	86.59% <82.6%> (-1.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11410ec...489522e. Read the comment docs.

[andyferris]

Looks good to me - thanks! Let's fix up those minor things and merge.

[andyferris]

I noticed one gotcha (that is also present in AngleAxis)

Yes, all of these structs need two parameters, unfortunately (one for the storage type and one for the computed element type).

[jw3126]

Anything left to do here?

[jw3126]

@andyferris merge?

[colinxs]

I'd love if you could merge this as well. I'm currently using a fork in a project that implements similar functionality, but would like to switch back to upstream for distribution.

[tkoolen]

Looks good to me, so I'm going to go ahead and merge this.