Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StaticArrays.Size definitions #287

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jipolanco
Copy link
Contributor

Closes #282.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f46b75) 90.50% compared to head (4ea263e) 90.41%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   90.50%   90.41%   -0.10%     
==========================================
  Files          17       17              
  Lines        1664     1658       -6     
==========================================
- Hits         1506     1499       -7     
- Misses        158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

The CI failure on Invalidation says:

Run echo "Invalidations on default branch: 108 (108 via deps)" >> $GITHUB_STEP_SUMMARY
  echo "Invalidations on default branch: 108 (108 via deps)" >> $GITHUB_STEP_SUMMARY
  echo "This branch: 99 (99 via deps)" >> $GITHUB_STEP_SUMMARY

The number of invalidations decreases and they are coming from dependency, so it should be okay to merge this PR.

@jipolanco
Copy link
Contributor Author

Sounds good to me!

@hyrodium hyrodium merged commit 549ec24 into JuliaGeometry:master Feb 5, 2024
8 of 10 checks passed
@jipolanco jipolanco deleted the jip/remove-Size branch February 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Size definitions?
2 participants