Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sinc to fix RotationVec near zero #272

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Use sinc to fix RotationVec near zero #272

merged 6 commits into from
Nov 12, 2023

Commits on Oct 12, 2023

  1. Use sinc to fix RotationVec near zero 

    By converting straight from RotationVec->QuatRotation,
and using an implementation that exploits `sinc` to handle θ ≈ 0,
we get continuous & differentiable behavior.
    @timholy
    timholy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    eec7cb9 View commit details
    Browse the repository at this point in the history

  2. Use new implementation only for small theta

    @timholy
    timholy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    74d6959 View commit details
    Browse the repository at this point in the history

  3. Relax adjoint test to approxeq

    @timholy
    timholy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4330c72 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Fix test with @test_broken

    @hyrodium
    hyrodium authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8dd986d View commit details
    Browse the repository at this point in the history

  2. Update tests for inv, adjoint, and transpose

    @hyrodium
    hyrodium authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    288b279 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Fix type instability

    @hyrodium
    hyrodium authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6811364 View commit details
    Browse the repository at this point in the history