remove some ambiguities

[hyrodium]

Before this PR

julia> using Rotations, Test

julia> detect_ambiguities(Rotations)
37-element Vector{Tuple{Method, Method}}:
 (RotY{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (RotX{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (Angle2dGenerator{T}(r) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:127, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotX(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotZ(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (Angle2dGenerator{T}(r) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:127, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (RotX(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotZ(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 ((::Type{Q})(q::AbstractVector) where Q<:QuatRotation in Rotations at /home/hyrodium/.julia/dev/Rotations/src/unitquaternion.jl:73, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotZ{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (RotY{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotY(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotY{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotX{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotX{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotY{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (RotX{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (RotY(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (RotY{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotZ(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotX(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotZ(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (Angle2dGenerator{T}(r) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:127, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (RotZ{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (RotZ{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotX(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (RotY(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (ones(::Type{R}, dims::Tuple{Vararg{Integer, N}}) where {R<:RotationGenerator, N} in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:24, ones(::Type{T}, dims::Tuple{}) where T in Base at array.jl:529)
 (RotZ(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}, T, 2} where {N, M, T}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:126)
 (Angle2dGenerator{T}(r) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:127, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)
 (RotY(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (RotX(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SA})(gen::Base.Generator) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/SArray.jl:54)
 (RotY(theta) in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:21, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotZ{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)
 (Angle2dGenerator{T}(r) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/rotation_generator.jl:127, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotX{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SM})(I::LinearAlgebra.UniformScaling) where SM<:(StaticArraysCore.StaticArray{Tuple{N, M}} where {N, M}) in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/linalg.jl:130)
 (RotZ{T}(theta) where T in Rotations at /home/hyrodium/.julia/dev/Rotations/src/euler_types.jl:17, (::Type{SA})(a::AbstractArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:169)

After this PR

julia> using Rotations, Test

julia> detect_ambiguities(Rotations)
1-element Vector{Tuple{Method, Method}}:
 ((::Type{Q})(q::AbstractVector) where Q<:QuatRotation in Rotations at /home/hyrodium/.julia/dev/Rotations/src/unitquaternion.jl:73, (::Type{SA})(sa::StaticArraysCore.StaticArray) where SA<:StaticArraysCore.StaticArray in StaticArrays at /home/hyrodium/.julia/dev/StaticArrays/src/convert.jl:165)

[codecov]

Codecov Report

Merging #236 (356927e) into master (524f61d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   88.70%   88.71%   +0.01%     
==========================================
  Files          16       16              
  Lines        1602     1604       +2     
==========================================
+ Hits         1421     1423       +2     
  Misses        181      181              

Impacted Files	Coverage Δ
src/euler_types.jl	92.25% <100.00%> (ø)
src/rotation_generator.jl	96.40% <100.00%> (+0.02%)	⬆️
src/unitquaternion.jl	96.20% <100.00%> (+0.01%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more