Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #91.
The
Statistics.mean(::AbstractArray{<:Rotations})
method should returnSMatrix
. (cf. #91 (comment))I've just removed the current definition of the method
mean(::AbstractArray{<:Rotations})
.Before this PR
After this PR
Note
I think the original method is useful if works fine, but the method should be renamed such as
mean_rotation
instead ofStatistics.mean
.This should be fixed in other PR, and I haven't removed the original file
src/mean.jl
.