Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inv method for RodriguesParam #156

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

hyrodium
Copy link
Collaborator

@hyrodium hyrodium commented May 2, 2021

This PR fixes #154.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #156 (fa29dc6) into master (38b208b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   85.40%   85.41%   +0.01%     
==========================================
  Files          12       12              
  Lines        1261     1262       +1     
==========================================
+ Hits         1077     1078       +1     
  Misses        184      184              
Impacted Files Coverage Δ
src/rodrigues_params.jl 98.63% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b208b...fa29dc6. Read the comment docs.

@hyrodium
Copy link
Collaborator Author

hyrodium commented May 3, 2021

julia> R = RodriguesParam(1,2,3)
3×3 RodriguesParam{Int64} with indices SOneTo(3)×SOneTo(3)(1, 2, 3):
 -0.733333  -0.133333  0.666667
  0.666667  -0.333333  0.666667
  0.133333   0.933333  0.333333

julia> inv(R)
3×3 RodriguesParam{Int64} with indices SOneTo(3)×SOneTo(3)(-1, -2, -3):
 -0.733333   0.666667  0.133333
 -0.133333  -0.333333  0.933333
  0.666667   0.666667  0.333333

@hyrodium hyrodium merged commit 3668fae into JuliaGeometry:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inv(::RodriguesParam) returns SMatrix
2 participants