Move the GeoInterface.jl code to an extension #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the issue of circular dependencies for GeoInterfaceMakie
|
What's the goal for this? I think GeoInterface is a pretty small dependency ... |
|
It was intended to remove a circular dependency but we don't actually need it. The issue was that any other geometry in e.g. ArchGDAL, LibGEOS, etc. is auto-enabled for conversion into Makie, but GeoInterface's wrapper geometries are not (and cannot be) since the capability to do so lies in GeoInterfaceMakie.jl, which depends on GeoInterface. What I can (probably) do is manually hook the GeoInterface geometries into the conversion system from Makie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.