Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Project.toml #50

Merged
merged 6 commits into from
Feb 14, 2020
Merged

Create Project.toml #50

merged 6 commits into from
Feb 14, 2020

Conversation

asinghvi17
Copy link
Contributor

No description provided.

@asinghvi17
Copy link
Contributor Author

This will make the package devable on 1.4. I kind of want to try and integrate GeometryTypes with this, it shouldn't be too hard at all...

@c42f
Copy link
Member

c42f commented Feb 12, 2020

Thanks! Looks like you need an [extras] section for the tests?

@asinghvi17
Copy link
Contributor Author

Yep, looks like I forgot that. Thanks!

@c42f
Copy link
Member

c42f commented Feb 12, 2020

Tests have failed still. Looks like you also need ForwardDiff in extras. I also suggest removing REQURE and test/REQURE as those will be obsolete.

@asinghvi17
Copy link
Contributor Author

CI is green...LGTM from my end!

@c42f c42f merged commit b1f8d46 into JuliaGeometry:master Feb 14, 2020
@mcabbott
Copy link

Came here to fix this, but you did it first!

However something still seems weird, as 0.5.0 is not listed here, and what is listed has tighter bounds on Compat.jl, which was causing me problems:

https://github.com/JuliaRegistries/General/blob/master/C/CoordinateTransformations/Compat.toml

Perhaps it needs to be re-registered?

@asinghvi17
Copy link
Contributor Author

Yeah, we should change bounds in the registry

@mcabbott
Copy link

Or simply release 0.5.1, I guess.

@c42f
Copy link
Member

c42f commented Feb 19, 2020

Yes, we should upgrade it to a new version 0.5.1.

Would be nice to aim for a 1.0 actually. Glancing over the issues, there's only #25 which really obviously needs something done about it.

@mcabbott
Copy link

That issue indeed looks close. But even if you do 1.0 tomorrow, it would be nice for 0.5.1 to exist with reasonable bounds, I think.

@c42f
Copy link
Member

c42f commented Feb 19, 2020

Absolutely agreed, I'll try to arrange 0.5.1.

@asinghvi17 asinghvi17 deleted the patch-1 branch February 20, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants