Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow MixedFormat in CRS #97

Merged
merged 4 commits into from
Oct 2, 2023
Merged

allow MixedFormat in CRS #97

merged 4 commits into from
Oct 2, 2023

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Sep 30, 2023 •
edited
Loading

Allow convert and CRS(crs) for <: MixedFormat objects other than <: MixedFormat{<:Geom}.

Closes #96

@rafaqz rafaqz mentioned this pull request Sep 30, 2023
Closed
@alex-s-gardner
Copy link
Contributor

tested on my end and works as expected

@rafaqz rafaqz requested a review from visr September 30, 2023 20:55
@alex-s-gardner alex-s-gardner mentioned this pull request Sep 30, 2023
Closed
visr
visr approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Tagging as 1.7

@visr visr merged commit 9baac70 into master Oct 2, 2023
11 checks passed
@visr visr deleted the crs_input_types branch October 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proj should accept GFT.MixedFormat input to CRS
3 participants
@rafaqz @alex-s-gardner @visr