Add Transformation constructor for pipeline and fix show for it. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
requested changes
Nov 6, 2022
There was a problem hiding this comment.
This is great to have, thanks. I also like the Base.show improvements.
- The new single arg AbstractString Transformation constructor is supposed to represent a pipeline. Can we check in the constructor after
proj_createif this is really the case, and throw an error if not? Or is there no PROJ API for that? I'm worried about people creating aProj.Transformation("EPSG:28992"), which (I guess) doesn't make much sense or will error. - Could you add a test for using the new constructor, including one that throws in the example above?
Merged
visr
approved these changes
Dec 15, 2022
visr
added a commit
that referenced
this pull request
Dec 19, 2022
visr
added a commit
that referenced
this pull request
Dec 22, 2022
visr
added a commit
that referenced
this pull request
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69