-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Proj.bounds function #72
Conversation
Now we've upgraded the library, we can expose this interface. See discussion in MakieOrg/GeoMakie.jl#101
There is also https://github.com/rafaqz/Extents.jl that we use in GeoInterface.jl and DimensionslData.jl/Rasters.jl for this. It's basically |
@rafaqz I'm not quite sure I understand: are you suggesting we import Extent into Proj, or import Proj into Extent? |
import Extent It's a tiny package just to have a shared wrapper for extents/bounding boxes. Maybe I misunderstand what your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for adding it!
@rafaqz it probably makes sense to also support Extents, but that can be done in a separate PR, right? Perhaps by adding a method to Proj.bounds that returns an Extent when that is the input? Or would this definition be in the way? |
Probably best to do that as another PR? I've opened MakieOrg/GeoMakie.jl#132, which uses this. |
Yeah it can totally be in another PR, I was just pointing out we mostly are using |
can we merge this and tag a new release? |
Now we've upgraded the library, we can expose this interface.
See discussion in MakieOrg/GeoMakie.jl#101