Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to a PROJ 6.1.0 build #23

Merged
merged 1 commit into from
May 20, 2019
Merged

switch to a PROJ 6.1.0 build #23

merged 1 commit into from
May 20, 2019

Conversation

visr
Copy link
Member

@visr visr commented May 18, 2019

PROJ has changed quite a bit in the past year, largely as a result of plans laid out in the GDAL barn raising (gdalbarn.com). For the build this means a dependency on SQLite, since the CSV EPSG file is no more, and the data now lives in a SQLite database named proj.db.

I started this build mainly since in GDAL 3.0 PROJ 6+ is needed, and I want a GDAL 3 build. I see from https://proj4.org/news.html that this also removes projects.h and deprecates proj_api.h (a new API is introduced).

This commit only updates the build. Rewrapping the APIs with Clang.jl can be done separately. Also generate_projection_codes.jl is not rerun, since it no longer works, since it should make use of proj.db. Updating that can also be done separately.

This also removes REQUIRE and adds Project.toml. I raised the minimum julia version to 1.0, since 0.7 is past end of life, or are there any objections to this?

PROJ has changed quite a bit in the past year, largely as a result of plans laid out in the GDAL barn raising (gdalbarn.com). For the build this means a dependency on SQLite, since the CSV EPSG file is no more, and the data now lives in a SQLite database named `proj.db`.

I started this build mainly since in GDAL 3.0 PROJ 6+ is needed, and I want a GDAL 3 build. I see from https://proj4.org/news.html that this also removes `projects.h` and deprecates `proj_api.h` (a new API is introduced).

This commit only updates the build. Rewrapping the APIs with Clang.jl can be done separately. Also `generate_projection_codes.jl` is not rerun, since it no longer works, since it should make use of `proj.db`. Updating that can also be done separately.

This also removes REQUIRE and adds Project.toml. I raised the minimum julia version to 1.0, since 0.7 is past end of life, or are there any objections to this?
@yeesian
Copy link
Member

yeesian commented May 19, 2019

LGTM.

Rewrapping the APIs with Clang.jl can be done separately. Also generate_projection_codes.jl is not rerun, since it no longer works, since it should make use of proj.db. Updating that can also be done separately.

Can you file these as issues if this gets merged?

@c42f
Copy link
Member

c42f commented May 19, 2019

Nice! I've been out of this for a while, but it's great to see some of the big problems which seemed permanently baked into the proj.4 API are being resolved.

By the way, I just saw the release notes for version 5.0, with their decision to change names: https://proj4.org/news.html#versioning-and-naming

With this in mind it probably makes sense to also change the name of Proj4.jl in the future.

@visr
Copy link
Member Author

visr commented May 20, 2019

With this in mind it probably makes sense to also change the name of Proj4.jl in the future.

Yeah indeed I was thinking the same thing. Let's rename it to PROJ.jl. Now that we switched to the new registry this should be easier, as it can keep the same UUID. Though didn't see any renames yet in General.

This was referenced May 20, 2019
@visr visr merged commit e72c6f3 into master May 20, 2019
@visr visr deleted the proj6 branch May 20, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants