Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrap using new Clang.jl #61

Merged
merged 2 commits into from
May 11, 2019
Merged

rewrap using new Clang.jl #61

merged 2 commits into from
May 11, 2019

Conversation

visr
Copy link
Member

@visr visr commented May 5, 2019

And include the used wrap_geos.jl, such that we can more easily wrap it again in the future.

As far as I can tell this is breaking, but not too badly, mainly because of some const that are now wrapped as a @cenum. This also adds the CEnum dependency, Clang.jl uses this instead of the normal julia @enum for C compatibility.

visr added 2 commits May 5, 2019 23:54
And include the used `wrap_geos.jl`, such that we can more easily wrap
it again in the future.

As far as I can tell this is breaking, but not too badly,
mainly because of some `const` that are now wrapped as a `@cenum`.
This also adds the CEnum dependency, Clang.jl uses this instead of the normal
julia `@enum` for C compatibility.
@visr visr requested a review from yeesian May 6, 2019 08:44
@yeesian
Copy link
Member

yeesian commented May 11, 2019

It's a pity the diff for src/geos_c.jl is hard to go through

@yeesian yeesian merged commit 12da12a into master May 11, 2019
@yeesian yeesian deleted the wrap branch May 11, 2019 15:16
@visr
Copy link
Member Author

visr commented May 11, 2019

Yeah it is. I just made a list of all the wrapped functions, and all the added functions can be seen here:
https://gist.github.com/visr/d4a8d1d6c3c93e6b2af1cdc72a223e10/revisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants