Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to geos 3.7.1 binaries, support more plaforms #56

Merged
merged 6 commits into from
Mar 29, 2019
Merged

Conversation

visr
Copy link
Member

@visr visr commented Nov 12, 2018

Note that there are several new functions added to the C API according to
https://trac.osgeo.org/geos/browser/git/NEWS?rev=3.7.0
These are not wrapped as part of this PR, but can be added separately.

@visr
Copy link
Member Author

visr commented Nov 12, 2018

Something is wrong on windows 64 bit, I also see it locally. No idea what though.

@visr
Copy link
Member Author

visr commented Nov 14, 2018

Loading LibGEOS works fine, but the first time it fails is on reading WKT strings: using LibGEOS; readgeom("POLYGON((0 0,1 0,1 1,0 0))")

Or lowered manually to a ccall:

using LibGEOS
c = LibGEOS._context
r = LibGEOS.WKTReader(c)
w = "POLYGON((0 0,1 0,1 1,0 0))"
ccall((:GEOSWKTReader_read_r,LibGEOS.libgeos),Ptr{LibGEOS.GEOSGeometry},(LibGEOS.GEOSContextHandle_t,Ptr{LibGEOS.GEOSWKTReader},Cstring),c.ptr, r.ptr, w)

It just goes poof and closes julia without saying anything. If anyone has any ideas, or how to debug, I'd be all ears :)

Don't see how this should only affect Windows 64 bit, unless the build is bad somehow.

visr added a commit to JuliaGeo/GEOSBuilder that referenced this pull request Dec 7, 2018
@visr visr changed the title update to geos 3.7.0 binaries, support more plaforms update to geos 3.7.1 binaries, support more plaforms Dec 8, 2018
@visr
Copy link
Member Author

visr commented Dec 8, 2018

Ok, updating to 3.7.1 which just came out fixes the old Win64 issue. Locally it works well on Win64, don't understand the error on AppVeyor though

Edit: scrap that, locally I see the same now, must have tested something else.

Makes no difference, still hitting JuliaPackaging/BinaryBuilder.jl#407
Which has expanded GCC versions, and uses
the workaround for the failing GCC4 builds as
described in
JuliaPackaging/BinaryBuilder.jl#407 (comment)
@visr visr merged commit 35c3487 into master Mar 29, 2019
@visr visr deleted the newgeos branch March 29, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant